fix(cli): wait for background tasks in run#28047
Open
PeterPonyu wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 similar comment
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26062
Type of change
What does this PR do?
Keeps non-interactive
opencode runsubscribed while background task child sessions are still running. This lets injected background results resume the parent session instead of returning as soon as the parent becomes idle.Adds a regression test for the parent-idle/background-child sequence.
How did you verify your code works?
bun test test/cli/run/noninteractive-background.test.ts test/cli/run/stream.transport.test.ts test/cli/run/subagent-data.test.ts test/tool/task.test.tsbun typecheckgit diff --checkbun turbo typecheckScreenshots / recordings
N/A, CLI behavior change.
Checklist